M1 Code Reviews
Instructions
Each team member must perform code reviews of other team members’ pull requests for Milestone M1.
- 2-Review Minimum. Each team member must review a minimum of 2 pull requests made by other teammates for Milestone M1.
- Follow the Workflow! The code reviews and pull-request merges into
main
must be performed as per the project workflow.
- Don’t Accept Broken Code! The code review must be thorough and obviously broken code must NOT be accepted into the
main
. Test the pull-request code thoroughly. If bugs are found, they must be fixed prior to acceptance of the pull request.
Grading Rubric
- High-Pass:
- 2 pull requests were reviewed and merged.
- No obviously broken code was allowed into the
main
branch.
- Low-Pass:
- At least 1 pull request was reviewed and merged.
- No obviously broken code was allowed into the
main
branch.
- Fail: Fails to meet requirements for Low-Pass.